Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for NML v2.3 release #168

Merged
merged 392 commits into from
Sep 20, 2023
Merged

Changes for NML v2.3 release #168

merged 392 commits into from
Sep 20, 2023

Conversation

pgleeson
Copy link
Member

@pgleeson pgleeson commented May 3, 2023

No description provided.

This is required for conversion to NEURON. The members themselves do not
need to be included.
The schema does not require the `name` attribute in `Segment`. However,
the NEURON code generator seems to require it:

```
Exception: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.neuroml.model.Segment.getName()" is null
```
… `Exception`

Specific errors are better than generic ones.
This is required to ensure that segment groups have already been defined
before they are included in the default ones.
No need for it to be limited to the utility function.
pgleeson and others added 24 commits June 22, 2023 19:08
otherwise sphinx fails with:

```
  File
  "/home/asinha/Documents/02_Code/00_mine/NeuroML/software/libNeuroML/neuroml/loaders.py",
  line 191, in <module>
      ) -> neuroml.nml.nml.NeuroMLDocument:
      AttributeError: module 'neuroml' has no attribute 'nml'

```

Not sure what the root cause is, but this tweak fixes it.
Given that we have a well defined structure, we should ideally be able
to generate all paths automatically. The information is present, we just
need to figure out how to use it.
Towards semi-automated path generation
Use natsort to properly sort segments/groups when optimising
@pgleeson pgleeson marked this pull request as ready for review September 20, 2023 18:54
@pgleeson pgleeson merged commit f3a0db6 into master Sep 20, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants